Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple media types inside content component #47

Merged
merged 2 commits into from
Oct 2, 2021

Conversation

melvinitcr
Copy link
Contributor

Added support for diff changes when there are multiple
media types inside a content component.

The diff changes include: added, deleted and modified
media types.

All modified media types are now indexed by the media type
name. This adds one extra element to the component hierarchy.

Updated README.md file and unit test accordingly.

Added support for diff changes when there are multiple
media types inside a content component.

The diff changes include: added, deleted and modified
media types.

All modified media types are now indexed by the media type
name. This adds one extra element to the component hierarchy.

Updated README.md file and unit test accordingly.
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Merging #47 (819a5f3) into main (fde406a) will decrease coverage by 0.58%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   92.68%   92.09%   -0.59%     
==========================================
  Files          63       64       +1     
  Lines        2842     2860      +18     
==========================================
  Hits         2634     2634              
- Misses        143      155      +12     
- Partials       65       71       +6     
Flag Coverage Δ
unittests 92.09% <84.00%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
report/report.go 79.86% <57.14%> (-1.17%) ⬇️
diff/content_diff.go 93.02% <89.28%> (+1.35%) ⬆️
diff/media_type_diff.go 90.90% <90.90%> (ø)
diff/parameter_diff.go 75.00% <0.00%> (-12.50%) ⬇️
diff/method_diff.go 90.00% <0.00%> (-5.00%) ⬇️
diff/parameters_diff.go 87.90% <0.00%> (-2.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde406a...819a5f3. Read the comment docs.

@reuvenharrison
Copy link
Collaborator

Great stuff - thanks for your contribution!

@reuvenharrison reuvenharrison merged commit cc53cdd into Tufin:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants