Add more cl checks #297
Add more cl checks #297
Conversation
blva
commented
Jun 13, 2023
•
blva
commented
- Add request body updated check
- Add localizations for all checkers
- Add OperationID update checker
- Add tag updated checker
- Add response status checkers
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 78.73% 78.84% +0.10%
==========================================
Files 164 164
Lines 9078 9122 +44
==========================================
+ Hits 7148 7192 +44
Misses 1667 1667
Partials 263 263
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Ciprian Tibulca <[email protected]>
checker/checker_not_breaking_test.go
Outdated
| verifyNonBreakingChangeIsChangelogEntry(t, d, osm, "api-tag-added") | ||
| } | ||
|
|
||
| // BC: adding an operation ID is not breaking with "api-operation-id-removed" check |
There was a problem hiding this comment.
Please update the omment to CL
There was a problem hiding this comment.
Updated, but let's discuss further at 9b30cba#r1233864561
BREAKING-CHANGES-EXAMPLES.md
Outdated
| @@ -82,11 +82,9 @@ These examples are automatically generated from unit tests. | |||
| [adding a new required property under AllOf in response body is not breaking](checker/checker_breaking_property_test.go?plain=1#L432) | |||
| [adding a new required read-only property in request body is not breaking](checker/checker_breaking_property_test.go?plain=1#L486) | |||
| [adding a non-existent required property in request body is not breaking](checker/checker_breaking_property_test.go?plain=1#L294) | |||
| [adding a tag is not breaking with "api-tag-removed" check](checker/checker_not_breaking_test.go?plain=1#L276) | |||
There was a problem hiding this comment.
@reuvenharrison I was reserving the CLcomments to checker_test files, and keeping the ones in checker_not_breaking as BC so that we keep this doc up to date.
If you look at the entries below we are ending up duplicating what are changelog entries. LMK what you think and if I can revert this commit.
