Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix property checks recursion #259

Merged

Conversation

reuvenharrison
Copy link
Collaborator

No description provided.

@reuvenharrison reuvenharrison linked an issue May 26, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #259 (e28ccf4) into main (7170fa8) will increase coverage by 0.37%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   76.49%   76.86%   +0.37%     
==========================================
  Files         152      152              
  Lines        8526     8525       -1     
==========================================
+ Hits         6522     6553      +31     
+ Misses       1670     1641      -29     
+ Partials      334      331       -3     
Flag Coverage Δ
unittests 76.86% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
checker/checks-utils.go 87.50% <100.00%> (+12.33%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@reuvenharrison reuvenharrison merged commit 84eac49 into main May 26, 2023
@reuvenharrison reuvenharrison deleted the 257-request-fields-were-optional-but-now-required branch May 26, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request fields were optional but now required
2 participants