Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sqlite3_interrupt (with fixed test) #631

Merged
merged 1 commit into from
May 15, 2016

Conversation

briangreenery
Copy link
Contributor

This reintroduces #518, fixing the test failure that caused it to be reverted in #630. The test failure was happening because the interrupt test used common table expressions, and common table expressions are not supported on older versions of sqlite. I removed the use of common table expressions in the interrupt test to fix it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 85.793% when pulling 434d0da on briangreenery:sqlite3-interrupt into 30ad7e5 on mapbox:master.

@springmeyer springmeyer merged commit dc076bf into TryGhost:master May 15, 2016
@briangreenery
Copy link
Contributor Author

I'm sorry this caused the build to fail again. I'm investigating this right now.

@mtgto mtgto mentioned this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants