Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build for Node.js 12 #1150

Closed
wants to merge 4 commits into from
Closed

Build for Node.js 12 #1150

wants to merge 4 commits into from

Conversation

thom4parisot
Copy link

fixes #1138

@thom4parisot thom4parisot changed the title Automatic release for Node.js 12 Build for Node.js 12 Apr 23, 2019
@thom4parisot
Copy link
Author

But apparently there is still a requirement to deploy the binaries manually, somewhere.

@Flarna Flarna mentioned this pull request Apr 25, 2019
Closed
@kewde kewde self-assigned this Apr 27, 2019
@kewde kewde closed this Apr 27, 2019
@kewde kewde reopened this Apr 27, 2019
@kewde
Copy link
Collaborator

kewde commented Apr 27, 2019

Triggered the CI again.

@kewde
Copy link
Collaborator

kewde commented Apr 27, 2019 •
edited
Loading

depends on #1145

@kewde
Copy link
Collaborator

kewde commented Apr 28, 2019

Node 12 is still not supported on AppVeyor.

downloading/installing node
node  x86 package not found
At C:\Program Files\AppVeyor\BuildAgent\Modules\avvm\avvm.psm1:106 char:17
+                 throw "$product $version $platform package not found"
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (node  x86 package not found:S 
   tring) [], RuntimeException
    + FullyQualifiedErrorId : node  x86 package not found
 
~~~~~~~~~~~~~~~~~~~~~~ ERROR C:\projects\node-sqlite3\scripts\build-appveyor.bat ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@kewde
Copy link
Collaborator

kewde commented Apr 28, 2019

Using Node 12 will automatically upgrade the Travis VM to Xenial, will also need the new XVFB service.

BridgeAR
BridgeAR reviewed May 1, 2019
View reviewed changes
Copy link

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a workaround for Appveyor:

appveyor/ci#2921 (comment)

@kewde
Copy link
Collaborator

kewde commented May 7, 2019

Closing in favor of #1158 & #1160

@kewde kewde closed this May 7, 2019
@thom4parisot thom4parisot deleted the patch-1 branch May 7, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

Assignees

@kewde kewde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release new version
3 participants
@thom4parisot @kewde @BridgeAR