node-pre-gyp is no longer maintained and is bugged for electron users #1721
Labels
Comments
This was referenced Oct 7, 2023
fcanela
changed the title
|
I'm looking into this :) |
daniellockyer
added a commit
that referenced
this issue
Dec 24, 2023
…stall` fixes #1641 fixes #1721 fixes #1714 fixes #1713 fixes #1700 fixes #1704 - `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs which our users keep running into - it seems the prebuilt binary world has moved in favor of prebuild + it's various other forms - one option would be to use prebuildify to bundle all binaries into the package, but that's a step too far removed from the current situation for now - instead, we can use prebuild-install to download the binaries, and `prebuild` to build + upload the binaries - this means we can remove node-pre-gyp and fix a bunch of issues! [1]: mapbox/node-pre-gyp#657
daniellockyer
added a commit
that referenced
this issue
Dec 24, 2023
…stall` fixes #1641 fixes #1721 fixes #1714 fixes #1713 fixes #1700 fixes #1704 - `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs which our users keep running into - it seems the prebuilt binary world has moved in favor of prebuild + it's various other forms - one option would be to use prebuildify to bundle all binaries into the package, but that's a step too far removed from the current situation for now - instead, we can use prebuild-install to download the binaries, and `prebuild` to build + upload the binaries - this means we can remove node-pre-gyp and fix a bunch of issues! - eventually, we could start providing electron prebuilt binaries too [1]: mapbox/node-pre-gyp#657
|
@daniellockyer thank you very much for the resolution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Summary
node-sqlite3depends onnode-pre-gyp(an unmaintained library [1]). That library does some conditional requiring of dependencies (aws-sdkandmock-aws-s2) that are places in "devDependencies", not "dependencies" ([2]) and this is causing troubles withelectron+sqlite3(among other users).This is related with the issues #1704, #1700 and #1691
[1] mapbox/node-pre-gyp#657
[2] mapbox/node-pre-gyp#661
Steps to Reproduce
Version
5.1.6
Node.js Version
20
How did you install the library?
Kubuntu 22.04, amd64
The text was updated successfully, but these errors were encountered: