Removed code disabling bluebird debug #21790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#14882 ref TryGhost#14882 (comment) - As per the comment on the issue, the last reference to bluebird in Ghost itself was removed over a year ago. - We added this code blocking bluebird debug over 6 years ago. - We do still use bluebird through dependencies so we could still have memory issues BUT - This change only affects development, and really should not be a problem anymore. - Leaning towards deleting the weird old edge-case code as it should not be an issue, and finding out the hard way if I'm wrong :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14882 ref #14882 (comment)