Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed image dimension retrieval causing Ghost requests to hang #20589

Merged
merged 4 commits into from
Jul 11, 2024

Commits on Jul 10, 2024

  1. Added fallback handling for failed image size retrieval

    ref https://linear.app/tryghost/issue/ENG-1408/
    - added additional safeguards to the image size dimensions probing
    
    For some reason that requires further investigation, the probe-image-size package was silently failing (neither resolving nor rejecting) for a particular URL. This was causing Ghost to hang on to serving the request, and after a few of these came in, ultimately caused Ghost to stop being responsive.
    
    Rather than trying to patch a dependency, we'll wrap the call to this package and use the same timeout we pass into the package (which is ignored in this particular case) as an additional safeguard.
    9larsons committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e5d166a View commit details
    Browse the repository at this point in the history
  2. linter

    9larsons committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4df66a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. re-add reject

    9larsons committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7620867 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7941a0 View commit details
    Browse the repository at this point in the history