Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed custom theme textfield rerendering #19714

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

ronaldlangeveld
Copy link
Member

@ronaldlangeveld ronaldlangeveld commented Feb 20, 2024

no issue

  • Changed the textfields in custom theme settings to use onBlur instead to trigger a rerender of the iFrame to avoid flashing.
  • It will now instead update once the text field loses focus, similar to the Announcement Bar.

no issue

- Changed the textfields in custom theme settings to use onBlur instead
  to trigger a rerender of the iFrame to avoid flashing.
- It will now instead update once the text field loses focus.
@github-actions github-actions bot added the affects:admin Anything relating to Ghost Admin label Feb 20, 2024
@ronaldlangeveld ronaldlangeveld marked this pull request as ready for review February 20, 2024 08:27
@ronaldlangeveld ronaldlangeveld changed the title Fixed custom theme settings rerendering 🐛 Fixed custom theme textfield rerendering Feb 20, 2024
@ronaldlangeveld ronaldlangeveld merged commit 1d0fe18 into main Feb 20, 2024
19 checks passed
@ronaldlangeveld ronaldlangeveld deleted the change-text-onblur branch February 20, 2024 08:28
royalfig pushed a commit that referenced this pull request Mar 25, 2024
no issue

- Changed the textfields in custom theme settings to use onBlur instead
to trigger a rerender of the iFrame to avoid flashing.
- It will now instead update once the text field loses focus, similar to
the Announcement Bar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin browser-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant