🐛 Fix edge case resulting in duplicate emails for some recipients #18941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmraible
approved these changes
Nov 10, 2023
9larsons
added a commit
that referenced
this pull request
Nov 10, 2023
…8941) refs https://ghost.slack.com/archives/CTH5NDJMS/p1699359241142969 It's possible for `ObjectIDs` to have only numeric characters. We were previously letting the type be inferred, which created a very rare but possible edge case where the last recipient of an email batch had a numeric ObjectID, resulting in a numeric comparison against alphanumeric `ObjectIDs` in the database. - updated the filter to add `'`'s around the `lastId` parameter - updated tests to check for the type of the id filter parameter value - can't fully test for numeric object IDs using what we have because javascript cannot handle numerics of that size; may be able to look at using fixture data loaded directly into the db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://ghost.slack.com/archives/CTH5NDJMS/p1699359241142969
It's possible for
ObjectIDsto have only numeric characters. We were previously letting the type be inferred, which created a very rare but possible edge case where the last recipient of an email batch had a numeric ObjectID, resulting in a numeric comparison against alphanumericObjectIDsin the database.''s around thelastIdparameter