Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Handled BOM character for Unicode encoded file uploads #17104

Merged

Conversation

vershwal
Copy link
Member

#16917

For details of how I debugged this issue, see this comment: #16917 (comment)

After this PR, I was able to upload the file provided in the issue and I have also tested it by uploading other files of ascii and utf-8 encoding.

image image

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (498e166) 71.59% compared to head (9ab6003) 71.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17104      +/-   ##
==========================================
+ Coverage   71.59%   71.62%   +0.02%     
==========================================
  Files        1817     1817              
  Lines      115364   115370       +6     
  Branches    17143    17147       +4     
==========================================
+ Hits        82600    82638      +38     
+ Misses      31638    31610      -28     
+ Partials     1126     1122       -4     
Flag Coverage Δ
e2e-tests 66.51% <ø> (+0.02%) ⬆️
unit-tests 63.47% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ghost/members-csv/lib/parse.js 81.81% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniellockyer daniellockyer self-assigned this Jun 22, 2023
@daniellockyer daniellockyer changed the title 🐛 Handled BOM character for Unicode-based encodings file uploads 🐛 Handled BOM character for Unicode encoded file uploads Jun 23, 2023
@daniellockyer daniellockyer merged commit 21085d0 into TryGhost:main Jun 23, 2023
@vershwal vershwal deleted the handling-bom-for-utf8-file-upload branch September 6, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants