Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed portal free trial message incorrectly showing #17095

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

mike182uk
Copy link
Member

no issue

Fixed portal free trial message incorrectly showing when signing up for free. Message was showing due to pageQuery erroneously not being passed down the call stack to getSiteProducts

no issue

Fixed portal free trial message incorrectly showing when signing up for free.
Message was showing due to `pageQuery` erroneously  not being passed down
the call stack to `getSiteProducts`
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (498e166) 71.59% compared to head (c53a96a) 71.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17095      +/-   ##
==========================================
- Coverage   71.59%   71.55%   -0.05%     
==========================================
  Files        1817     1817              
  Lines      115364   115364              
  Branches    17143    17121      -22     
==========================================
- Hits        82600    82548      -52     
- Misses      31638    31697      +59     
+ Partials     1126     1119       -7     
Flag Coverage Δ
e2e-tests 66.56% <ø> (+0.08%) ⬆️
unit-tests 63.37% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mike182uk mike182uk merged commit a79035c into TryGhost:main Jun 22, 2023
@mike182uk mike182uk deleted the fix-portal-free-trial-message branch June 22, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant