Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed emojis from i18n strings #16429

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Removed emojis from i18n strings #16429

merged 1 commit into from
Mar 16, 2023

Conversation

daniellockyer
Copy link
Member

refs #15502

  • these aren't going to change across languages so we can exclude them from the strings to simplify things

refs #15502

- these aren't going to change across languages so we can exclude them
  from the strings to simplify things
@daniellockyer daniellockyer added the running-ci-checks PR's which do not need/want review label Mar 16, 2023
@daniellockyer daniellockyer self-assigned this Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -20.58 ⚠️

Comparison is base (d04b2e0) 83.62% compared to head (7a1f08e) 63.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #16429       +/-   ##
===========================================
- Coverage   83.62%   63.04%   -20.58%     
===========================================
  Files        1031      935       -96     
  Lines       83645    75622     -8023     
  Branches    12093     7420     -4673     
===========================================
- Hits        69948    47677    -22271     
- Misses      13623    27879    +14256     
+ Partials       74       66        -8     
Flag Coverage Δ
e2e-tests ?
unit-tests 63.04% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ghost/core/core/server/services/members/api.js 0.00% <0.00%> (-81.91%) ⬇️
...core/core/server/services/members/emails/signin.js 0.00% <0.00%> (-100.00%) ⬇️

... and 493 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniellockyer daniellockyer merged commit dda1d7c into main Mar 16, 2023
@daniellockyer daniellockyer deleted the i18n-emoji branch March 16, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
running-ci-checks PR's which do not need/want review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant