🐛 Fixed default email recipients always being "everyone" rather than matching post visibility #16247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matching post visibility refs TryGhost#16125 The previous fix for incorrect recipient details being shown when re-sending a failed email introduced another bug that prevented the "Match post visibility" default recipients setting from working. - the server always sets `post.emailSegment` to `'all'` for new posts so the publish flow recipient filter logic that checked for `post.emailSegment` being present always defaulted to `'all'` rather than falling back to the selected default recipients setting - when a post has been published but the email failed it will have its `newsletter` value set so we can use that as a check for using the `post.emailSegment` value in place of the default recipients setting
Codecov ReportBase: 72.26% // Head: 55.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #16247 +/- ##
===========================================
- Coverage 72.26% 55.95% -16.31%
===========================================
Files 1747 1672 -75
Lines 111392 105336 -6056
Branches 16812 12214 -4598
===========================================
- Hits 80502 58946 -21556
- Misses 29582 45081 +15499
- Partials 1308 1309 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
daniellockyer
pushed a commit
that referenced
this pull request
Feb 9, 2023
…matching post visibility (#16247) refs #16125 The previous fix for incorrect recipient details being shown when re-sending a failed email introduced another bug that prevented the "Match post visibility" default recipients setting from working. - the server always sets `post.emailSegment` to `'all'` for new posts so the publish flow recipient filter logic that checked for `post.emailSegment` being present always defaulted to `'all'` rather than falling back to the selected default recipients setting - when a post has been published but the email failed it will have its `newsletter` value set so we can use that as a check for using the `post.emailSegment` value in place of the default recipients setting
|
Aren't there any tests in Ghost that could prevent such regressions from happening? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #16125
The previous fix for incorrect recipient details being shown when re-sending a failed email introduced another bug that prevented the "Match post visibility" default recipients setting from working.
post.emailSegmentto'all'for new posts so the publish flow recipient filter logic that checked forpost.emailSegmentbeing present always defaulted to'all'rather than falling back to the selected default recipients settingnewslettervalue set so we can use that as a check for using thepost.emailSegmentvalue in place of the default recipients setting