Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added i18n package #16145

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Added i18n package #16145

merged 1 commit into from
Jan 18, 2023

Conversation

daniellockyer
Copy link
Member

@daniellockyer daniellockyer commented Jan 18, 2023

refs #15502

  • this is an early implementation of an i18n provider by exporting an instance of i18next
  • there's a lot more to be done here but baby steps :)

@daniellockyer daniellockyer added the running-ci-checks PR's which do not need/want review label Jan 18, 2023
@daniellockyer daniellockyer self-assigned this Jan 18, 2023
refs #15502

- this is an early implementation of an i18n provider by
  exporting an instance of `i18next`
- there's a lot more to be done here but baby steps :)
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 71.71% // Head: 71.72% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6c1e6eb) compared to base (2dc9c7d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16145   +/-   ##
=======================================
  Coverage   71.71%   71.72%           
=======================================
  Files        1723     1727    +4     
  Lines      109240   109297   +57     
  Branches    16430    16445   +15     
=======================================
+ Hits        78341    78392   +51     
- Misses      29597    29602    +5     
- Partials     1302     1303    +1     
Flag Coverage Δ
e2e-tests 85.00% <ø> (+<0.01%) ⬆️
unit-tests 55.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ghost/i18n/index.js 100.00% <100.00%> (ø)
ghost/i18n/lib/i18n.js 100.00% <100.00%> (ø)
ghost/i18n/locales/en.js 100.00% <100.00%> (ø)
ghost/i18n/locales/nl.js 100.00% <100.00%> (ø)
...tor/lib/tables/members-paid-subscription-events.js 89.74% <0.00%> (-10.26%) ⬇️
...a-generator/lib/tables/members-subscribe-events.js 94.33% <0.00%> (-5.67%) ⬇️
ghost/admin/app/components/gh-file-uploader.js 83.07% <0.00%> (-3.08%) ⬇️
...t/core/core/server/data/importer/import-manager.js 89.35% <0.00%> (-2.29%) ⬇️
ghost/admin/app/services/ajax.js 76.27% <0.00%> (-1.77%) ⬇️
ghost/data-generator/lib/tables/members.js 98.48% <0.00%> (-1.52%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniellockyer daniellockyer merged commit 0d9268a into main Jan 18, 2023
@daniellockyer daniellockyer deleted the i18n branch January 18, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
running-ci-checks PR's which do not need/want review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant