Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed using Offers with Stripe Checkout v2 #15749

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

allouis
Copy link
Contributor

@allouis allouis commented Nov 1, 2022

refs 1f300fb781f0

The Stripe API was giving inconsistent responses when passing the customerEmail param, sometimes it would allow a null/empty value and sometimes it wouldn't. In order to support both behaviours we need to not attach the customerEmail at all unless necessary.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 53.42% // Head: 53.41% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b9797bc) compared to base (7fda360).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head b9797bc differs from pull request most recent head db340b9. Consider uploading reports for the commit db340b9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           v5.22.4   #15749      +/-   ##
===========================================
- Coverage    53.42%   53.41%   -0.02%     
===========================================
  Files         1502     1502              
  Lines        97935    97940       +5     
  Branches     10978    10980       +2     
===========================================
- Hits         52322    52314       -8     
- Misses       44355    44367      +12     
- Partials      1258     1259       +1     
Impacted Files Coverage Δ
ghost/payments/lib/payments.js 0.00% <0.00%> (ø)
.../data-generator/lib/tables/members-login-events.js 90.69% <0.00%> (-9.31%) ⬇️
ghost/admin/app/components/gh-file-uploader.js 82.94% <0.00%> (-3.11%) ⬇️
ghost/data-generator/lib/tables/posts.js 89.39% <0.00%> (-1.52%) ⬇️
...host/data-generator/lib/tables/members-products.js 100.00% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

refs 1f300fb781f0

The Stripe API was giving inconsistent responses when passing the
customerEmail param, sometimes it would allow a null/empty value and
sometimes it wouldn't. In order to support both behaviours we need to
not attach the customerEmail at all unless necessary.
@allouis allouis merged commit 1ff1b75 into v5.22.4 Nov 1, 2022
@allouis allouis deleted the offers-fix branch November 1, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant