Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for page.rescheduled webhook #15736

Merged
merged 6 commits into from
Nov 5, 2022
Merged

Added e2e tests for page.rescheduled webhook #15736

merged 6 commits into from
Nov 5, 2022

Conversation

leonyangela
Copy link
Contributor

refs #15537

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 53.40% // Head: 53.41% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8daa3e2) compared to base (f761bd3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15736   +/-   ##
=======================================
  Coverage   53.40%   53.41%           
=======================================
  Files        1502     1502           
  Lines       97922    97922           
  Branches    10978    10977    -1     
=======================================
+ Hits        52298    52305    +7     
+ Misses      44366    44359    -7     
  Partials     1258     1258           
Impacted Files Coverage Δ
...tor/lib/tables/members-paid-subscription-events.js 89.74% <0.00%> (-10.26%) ⬇️
...a-generator/lib/tables/members-subscribe-events.js 94.23% <0.00%> (-5.77%) ⬇️
ghost/data-generator/lib/tables/members.js 98.46% <0.00%> (-1.54%) ⬇️
ghost/data-generator/lib/tables/posts.js 89.39% <0.00%> (-1.52%) ⬇️
...host/data-generator/lib/tables/members-products.js 100.00% <0.00%> (+2.85%) ⬆️
ghost/admin/app/components/gh-file-uploader.js 86.04% <0.00%> (+3.10%) ⬆️
...b/tables/members-stripe-customers-subscriptions.js 100.00% <0.00%> (+4.16%) ⬆️
ghost/data-generator/lib/tables/subscriptions.js 100.00% <0.00%> (+7.81%) ⬆️
.../data-generator/lib/tables/members-login-events.js 100.00% <0.00%> (+9.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErisDS ErisDS mentioned this pull request Nov 2, 2022
29 tasks
@ErisDS ErisDS requested a review from naz November 2, 2022 17:24
Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome effort @leonyangela ✊ Thanks for yet another great contribution!

@ErisDS ErisDS changed the title Added e2e tests for page.rescheduled webhook Added e2e tests for page.rescheduled webhook Nov 5, 2022
@ErisDS ErisDS merged commit e8d8e07 into TryGhost:main Nov 5, 2022
@ErisDS
Copy link
Member

ErisDS commented Nov 5, 2022

Thanks again, this one has been merged now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants