Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for page.published.edited webhook #15724

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

RobinCsl
Copy link
Contributor

@RobinCsl RobinCsl commented Oct 29, 2022

Contributes to this issue: #15537

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org

@naz naz self-assigned this Oct 31, 2022
Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for the time and very precise contribution @RobinCsl 🙌

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 53.39% // Head: 53.41% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9447cae) compared to base (79c80f2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15724      +/-   ##
==========================================
+ Coverage   53.39%   53.41%   +0.01%     
==========================================
  Files        1502     1502              
  Lines       97916    97916              
  Branches    10972    10973       +1     
==========================================
+ Hits        52287    52301      +14     
+ Misses      44373    44358      -15     
- Partials     1256     1257       +1     
Impacted Files Coverage Δ
...host/data-generator/lib/tables/members-products.js 97.14% <0.00%> (-2.86%) ⬇️
ghost/admin/app/components/gh-image-uploader.js 84.35% <0.00%> (-2.73%) ⬇️
ghost/admin/app/utils/publish-options.js 76.87% <0.00%> (+1.15%) ⬆️
...ata-generator/lib/tables/members-created-events.js 100.00% <0.00%> (+5.71%) ⬆️
ghost/data-generator/lib/tables/posts-tags.js 100.00% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RobinCsl RobinCsl force-pushed the rcsl/pages.published.edited branch from a459684 to 671f52d Compare October 31, 2022 09:48
@RobinCsl
Copy link
Contributor Author

Hi @naz, I fixed the merge conflict. Many thanks :)

@ErisDS ErisDS force-pushed the rcsl/pages.published.edited branch from 671f52d to 05cd68c Compare October 31, 2022 15:31
@ErisDS ErisDS force-pushed the rcsl/pages.published.edited branch from 05cd68c to 9447cae Compare October 31, 2022 19:36
@ErisDS ErisDS changed the title Added e2e tests for page.published.edited webhook (#15537) Added e2e tests for page.published.edited webhook Oct 31, 2022
@ErisDS ErisDS merged commit e7e12ab into TryGhost:main Oct 31, 2022
@ErisDS
Copy link
Member

ErisDS commented Oct 31, 2022

Hi @RobinCsl thanks so much for this PR. It has now been merged 🎉 and will appear in the next release of Ghost - usually Fridays.

I've added the hacktoberfest-accepted label to this PR as well as the others that aren't quite ready yet. We have plenty of open issues and ongoing projects for hacktoberfest and beyond. We would love to see you continue to get involved ❤️

@RobinCsl RobinCsl deleted the rcsl/pages.published.edited branch October 31, 2022 21:34
@ErisDS ErisDS mentioned this pull request Nov 2, 2022
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants