-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added e2e tests for page.published.edited
webhook
#15724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for the time and very precise contribution @RobinCsl 🙌
Codecov ReportBase: 53.39% // Head: 53.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15724 +/- ##
==========================================
+ Coverage 53.39% 53.41% +0.01%
==========================================
Files 1502 1502
Lines 97916 97916
Branches 10972 10973 +1
==========================================
+ Hits 52287 52301 +14
+ Misses 44373 44358 -15
- Partials 1256 1257 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a459684
to
671f52d
Compare
Hi @naz, I fixed the merge conflict. Many thanks :) |
671f52d
to
05cd68c
Compare
Contributes to this issue: TryGhost#15537
05cd68c
to
9447cae
Compare
page.published.edited
webhook
Hi @RobinCsl thanks so much for this PR. It has now been merged 🎉 and will appear in the next release of Ghost - usually Fridays. I've added the |
Contributes to this issue: #15537
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:all
andyarn lint
)We appreciate your contribution!
Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org