Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for page.deleted webhook #15723

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

RobinCsl
Copy link
Contributor

Contributes to this issue: #15537

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org

@naz naz self-assigned this Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 53.42% // Head: 53.40% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (8d46ab0) compared to base (2d2ac01).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15723      +/-   ##
==========================================
- Coverage   53.42%   53.40%   -0.03%     
==========================================
  Files        1502     1502              
  Lines       97925    97925              
  Branches    10979    10976       -3     
==========================================
- Hits        52319    52295      -24     
- Misses      44348    44371      +23     
- Partials     1258     1259       +1     
Impacted Files Coverage Δ
ghost/admin/app/helpers/gh-price-amount.js 44.44% <0.00%> (-22.23%) ⬇️
ghost/data-generator/lib/tables/subscriptions.js 89.06% <0.00%> (-10.94%) ⬇️
...tor/lib/tables/members-paid-subscription-events.js 89.74% <0.00%> (-10.26%) ⬇️
.../data-generator/lib/tables/members-login-events.js 90.69% <0.00%> (-9.31%) ⬇️
...a-generator/lib/tables/members-subscribe-events.js 94.23% <0.00%> (-5.77%) ⬇️
...b/tables/members-stripe-customers-subscriptions.js 95.83% <0.00%> (-4.17%) ⬇️
ghost/data-generator/lib/tables/members.js 98.46% <0.00%> (-1.54%) ⬇️
ghost/admin/app/controllers/offer.js 41.57% <0.00%> (-0.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for yet another great contribution @RobinCsl 🙌 These changes are good and do the job intended.

I think we'll need to establish a cleaner "matcher building" pattern in the future, but that's a change for another PR. Would appreciate your ideas and another PR if you have time to tackle it!

@ErisDS ErisDS mentioned this pull request Nov 2, 2022
29 tasks
@ErisDS ErisDS changed the title Added e2e tests for page.deleted webhook (#15537) Added e2e tests for page.deleted webhook Nov 2, 2022
@ErisDS ErisDS merged commit 0bccbcb into TryGhost:main Nov 2, 2022
@ErisDS
Copy link
Member

ErisDS commented Nov 2, 2022

@RobinCsl thanks so much for this PR, it's now been merged - I added the hactoberfest-accepted label a few days ago so that it should have counted.

I think we actually have a PR merged or open for every single webhook now, incredible! Thank you for helping 🙏 I hope you'll stick around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants