-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added e2e tests for page.deleted
webhook
#15723
Conversation
Codecov ReportBase: 53.42% // Head: 53.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15723 +/- ##
==========================================
- Coverage 53.42% 53.40% -0.03%
==========================================
Files 1502 1502
Lines 97925 97925
Branches 10979 10976 -3
==========================================
- Hits 52319 52295 -24
- Misses 44348 44371 +23
- Partials 1258 1259 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
81ee418
to
264afc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for yet another great contribution @RobinCsl 🙌 These changes are good and do the job intended.
I think we'll need to establish a cleaner "matcher building" pattern in the future, but that's a change for another PR. Would appreciate your ideas and another PR if you have time to tackle it!
page.deleted
webhook
@RobinCsl thanks so much for this PR, it's now been merged - I added the I think we actually have a PR merged or open for every single webhook now, incredible! Thank you for helping 🙏 I hope you'll stick around! |
Contributes to this issue: #15537
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:all
andyarn lint
)We appreciate your contribution!
Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org