-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added e2e tests for page.unscheduled webhook #15722
Conversation
Codecov ReportBase: 72.07% // Head: 72.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15722 +/- ##
=======================================
Coverage 72.07% 72.07%
=======================================
Files 1740 1740
Lines 110387 110387
Branches 16646 16643 -3
=======================================
+ Hits 79558 79565 +7
+ Misses 29520 29515 -5
+ Partials 1309 1307 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RobinCsl! The changes are great, just need to fix the linting error. Otherwise the code is good to land in the main branch. Thank a lot for the contribution 😊
Note from our bot: Some changes have been requested on this pull request. Updating your code is great, but won't notify us, so please leave a comment so that we (and our bot) can see when you've made the changes. Thank you 🙏 |
Hey @naz! Thanks a lot! :) I fixed the linting issues and merge conflicts. Could you please take another look? Not sure about your flow, but will you squash the commits automatically or I shall do it? |
Hello again, @naz, would you mind setting the PRs I created as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @RobinCsl
681f683
to
ea90807
Compare
Contributes to this issue: TryGhost#15537
ea90807
to
ceaeeb2
Compare
Hey @ErisDS, I just rebased the branch on main, it should be all good now 🤞 |
Hey @RobinCsl thanks for that! I rebased it a week or more ago as I didn't wanna ask you to do it after taking soooo long to get to it 🙈, but have been butting against broken tests in main meaning it never went green! Thankfully you caught it at a good moment and got the ✅ This is the very last one of these, thank you so much 🙌 🙌 🙌 🙌 And sorry again for being so slooooow 🙈 |
No worries at all, glad I could help. 🙂 |
refs: TryGhost#15537 - snapshot test created to add confidence to webhook stability and increase overall test coverage.
Contributes to this issue: #15537
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:all
andyarn lint
)We appreciate your contribution!
Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org