Added e2e tests for page.tag.attached webhook
#15648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.40% // Head: 52.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15648 +/- ##
==========================================
- Coverage 53.40% 52.74% -0.66%
==========================================
Files 1502 1470 -32
Lines 97873 96161 -1712
Branches 10958 10765 -193
==========================================
- Hits 52269 50721 -1548
+ Misses 44345 44179 -166
- Partials 1259 1261 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
naz
reviewed
Oct 19, 2022
naz
reviewed
Oct 19, 2022
naz
reviewed
Oct 19, 2022
| @@ -23,6 +24,17 @@ const tierSnapshot = { | |||
|
|
|||
| const roleSnapshot = tierSnapshot; | |||
|
|
|||
| const tagSnapshot = { | |||
There was a problem hiding this comment.
The tag's name, slug, visibility etc. are not changing between test runs? If they are not, would be best to have snapshot capture them as is - no need to include non-dynamic properties in the snapshot matcher object 👍
naz
reviewed
Oct 19, 2022
naz
suggested changes
Oct 19, 2022
There was a problem hiding this comment.
Hey @leonyangela! Thanks for taking time to make the contribution. It's in pretty good shape just needs to polish up a few rough edges. I've left some guiding comments in the PR for the improvements. Feel free to reach out if you need more guidance 😊
|
Note from our bot: Some changes have been requested on this pull request. Updating your code is great, but won't notify us, so please leave a comment so that we (and our bot) can see when you've made the changes. Thank you 🙏 |
|
Hi @naz, Thanks for your feedback. I've made another changes. I've tried to run Do you have any idea for this? I also made a changes on tagSnapshot, please let me know if there's more feedback. Thank you. |
|
Hi @naz, I've updated the tagSnapshot and made some changes. Please let me know if there's any more feedback, cheers! |
|
Hey @leonyangela , just a heads up there are some linting errors that need to be fixed. The rest of the code is heading in a right direction 👍 |
|
Hi @naz, the lint test flow keeps failing, I have no idea on this, any suggestions? Result after I commit: |
naz
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
The linting passed! 🚀 You got there eventually @leonyangela , thanks for the effort and great contribution 💪
|
ah great, thank you @naz. |
ref #15537 🎨 Update tagSnapshot 🎨 Update buildPreviousPageSnapshotWithTiersAndTags function
ErisDS
changed the title
page.tag.attached webhook
|
Hi @leonyangela thanks so much for this PR. It has now been merged 🎉 FYI I had to rebase it as it conflicted with changes made to add the I'm not sure if you found this through hacktoberfest, but I've added the |
|
Hi @ErisDS, thank you. Yes, I found this from hacktoberfest, thanks for adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15537
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:allandyarn lint)We appreciate your contribution!
Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org