Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e test for site.changed webhook event #15595

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

hthorhalls
Copy link
Contributor

@hthorhalls hthorhalls commented Oct 12, 2022

#15537
There's a lot of API calls that can trigger a site.changed webhook event. I just cherry-picked deleting a post. If there's a more generic way to write this test I'm all ears.

@naz naz self-requested a review October 12, 2022 02:34
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 52.32% // Head: 52.32% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c94db10) compared to base (68bdc1a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15595   +/-   ##
=======================================
  Coverage   52.32%   52.32%           
=======================================
  Files        1446     1446           
  Lines       93469    93469           
  Branches    10432    10432           
=======================================
+ Hits        48907    48909    +2     
+ Misses      43336    43335    -1     
+ Partials     1226     1225    -1     
Impacted Files Coverage Δ
ghost/admin/app/components/gh-image-uploader.js 85.71% <0.00%> (+1.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change suggestion regarding triggering 'site.changed' event. The rest looks awesome! Thanks @halldorbjarni 🙌

ghost/core/test/e2e-webhooks/site.test.js Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Note from our bot: Some changes have been requested on this pull request. Updating your code is great, but won't notify us, so please leave a comment so that we (and our bot) can see when you've made the changes. Thank you 🙏

@hthorhalls
Copy link
Contributor Author

Updated to only upload a single post. I don't see a squash and merge option, @naz do you want me to squash locally and push or is this something maintainers can do from the UI when merging?

@hthorhalls hthorhalls requested a review from naz October 12, 2022 13:24
@ErisDS
Copy link
Member

ErisDS commented Oct 12, 2022

Hey @halldorbjarni, we can squash our side so no worries about that 🙂 we'll get this reviewed again ASAP.

Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is great. Thanks @halldorbjarni 🙌

@ErisDS ErisDS changed the title Added e2e test for site.changed webhook event (#15537) Added e2e test for site.changed webhook event Oct 13, 2022
@ErisDS ErisDS merged commit 74f7b7b into TryGhost:main Oct 13, 2022
@ErisDS
Copy link
Member

ErisDS commented Oct 13, 2022

Hi @halldorbjarni thanks so much for creating and taking the time to update this PR for us.

It has now been merged 🎉 and will appear in the next release of Ghost - usually Fridays.

I'm not sure if you found this through hacktoberfest, but I've added the hacktoberfest-accepted label to this PR to make sure it counts.

We have many open issues and ongoing projects for hacktoberfest and beyond. We would love to see you contribute some more ❤️

sam-lord pushed a commit that referenced this pull request Oct 17, 2022
refs: #15537

- snapshot test created to add confidence to webhook stability and increase overall test coverage.
@naz naz mentioned this pull request Oct 19, 2022
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants