-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added e2e test for site.changed
webhook event
#15595
Conversation
Codecov ReportBase: 52.32% // Head: 52.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15595 +/- ##
=======================================
Coverage 52.32% 52.32%
=======================================
Files 1446 1446
Lines 93469 93469
Branches 10432 10432
=======================================
+ Hits 48907 48909 +2
+ Misses 43336 43335 -1
+ Partials 1226 1225 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change suggestion regarding triggering 'site.changed' event. The rest looks awesome! Thanks @halldorbjarni 🙌
Note from our bot: Some changes have been requested on this pull request. Updating your code is great, but won't notify us, so please leave a comment so that we (and our bot) can see when you've made the changes. Thank you 🙏 |
Updated to only upload a single post. I don't see a squash and merge option, @naz do you want me to squash locally and push or is this something maintainers can do from the UI when merging? |
Hey @halldorbjarni, we can squash our side so no worries about that 🙂 we'll get this reviewed again ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is great. Thanks @halldorbjarni 🙌
site.changed
webhook event
Hi @halldorbjarni thanks so much for creating and taking the time to update this PR for us. It has now been merged 🎉 and will appear in the next release of Ghost - usually Fridays. I'm not sure if you found this through hacktoberfest, but I've added the We have many open issues and ongoing projects for hacktoberfest and beyond. We would love to see you contribute some more ❤️ |
refs: #15537 - snapshot test created to add confidence to webhook stability and increase overall test coverage.
#15537
There's a lot of API calls that can trigger a
site.changed
webhook event. I just cherry-picked deleting a post. If there's a more generic way to write this test I'm all ears.