Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for post.tag.attached webhook #15576

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

kritikash18
Copy link
Contributor

Added e2e tests for post.tag.attached webhook

Ref - #15537

@daniellockyer daniellockyer requested a review from naz October 10, 2022 07:49
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 52.32% // Head: 52.32% // No change to project coverage 👍

Coverage data is based on head (d6893b8) compared to base (0bc31de).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15576   +/-   ##
=======================================
  Coverage   52.32%   52.32%           
=======================================
  Files        1446     1446           
  Lines       93505    93505           
  Branches    10439    10439           
=======================================
  Hits        48928    48928           
- Misses      43350    43351    +1     
+ Partials     1227     1226    -1     
Impacted Files Coverage Δ
ghost/admin/app/components/gh-file-uploader.js 82.94% <0.00%> (-3.11%) ⬇️
ghost/admin/app/utils/publish-options.js 76.87% <0.00%> (+1.15%) ⬆️
ghost/admin/app/components/gh-image-uploader.js 85.71% <0.00%> (+1.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @kritikash18 🙌

@naz naz mentioned this pull request Oct 11, 2022
29 tasks
@ErisDS ErisDS force-pushed the e2e-test-post-tag-attached branch from aadb739 to d6893b8 Compare October 12, 2022 20:28
@ErisDS ErisDS changed the title Added e2e test for post.tag.attached webhook (#15537) Added e2e tests for post.tag.attached webhook Oct 12, 2022
@ErisDS ErisDS merged commit 2cb4282 into TryGhost:main Oct 12, 2022
@ErisDS
Copy link
Member

ErisDS commented Oct 12, 2022

Hey @kritikash18 thank you for this 2nd PR! Took me a little while to get it merged as it needed a rebase, but it's merged now.

Have added the hacktoberfest-accepted label again so it'll count. Would love to see you do more ❤️

kritikash18 pushed a commit to kritikash18/Ghost that referenced this pull request Oct 13, 2022
sam-lord pushed a commit that referenced this pull request Oct 17, 2022
refs: #15537

- snapshot test created to add confidence to webhook stability and increase overall test coverage.

Co-authored-by: Kritika Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants