Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for post.deleted webhook #15572

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

kritikash18
Copy link
Contributor

@kritikash18 kritikash18 commented Oct 9, 2022

Added e2e tests for post.deleted webhook

Ref - #15537

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 52.43% // Head: 52.42% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (bfe99be) compared to base (786e0ac).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15572      +/-   ##
==========================================
- Coverage   52.43%   52.42%   -0.01%     
==========================================
  Files        1438     1438              
  Lines       93031    93031              
  Branches    10393    10393              
==========================================
- Hits        48781    48776       -5     
- Misses      43025    43030       +5     
  Partials     1225     1225              
Impacted Files Coverage Δ
ghost/admin/app/components/gh-image-uploader.js 84.35% <0.00%> (-2.73%) ⬇️
ghost/admin/app/components/gh-site-iframe.js 43.18% <0.00%> (-2.28%) ⬇️
ghost/admin/app/components/gh-dropdown.js 89.79% <0.00%> (-2.05%) ⬇️
ghost/admin/app/controllers/offer.js 41.57% <0.00%> (-0.53%) ⬇️
ghost/admin/app/helpers/gh-price-amount.js 66.66% <0.00%> (+22.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alles gut! Thanks @kritikash18 🙌

@ErisDS ErisDS changed the title Added e2e test for post.deleted webhook (#15537) Added e2e tests for post.deleted webhook Oct 12, 2022
@ErisDS ErisDS merged commit 2ce0727 into TryGhost:main Oct 12, 2022
@ErisDS
Copy link
Member

ErisDS commented Oct 12, 2022

Hi @kritikash18 thanks so much for this PR. Sorry for the delay here but it has now been merged 🎉 and will appear in the next release of Ghost - usually Fridays.

I'm not sure if you found this through hacktoberfest, but I've added the accepted label to this PR to make sure it counts. We have plenty of open issues and ongoing projects for hacktoberfest and beyond. We would love to see you around again 👋

sam-lord pushed a commit that referenced this pull request Oct 17, 2022
refs: #15537

- Added  missing e2e tests for post.deleted webhook to increase coverage 

Co-authored-by: Kritika Sharma <[email protected]>
@naz naz mentioned this pull request Oct 19, 2022
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants