Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e test for tag.deleted webhook #15553

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Added e2e test for tag.deleted webhook #15553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06a6d5e
Added e2e tests for tag.deleted webhook
dshubhadeep Oct 7, 2022
e422847
minor refactor
dshubhadeep Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions ghost/core/test/e2e-webhooks/__snapshots__/tags.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,43 @@ Object {
},
}
`;

exports[`tag.* events tag.deleted event is triggered 1: [headers] 1`] = `
Object {
"accept-encoding": "gzip, deflate",
"content-length": Any<Number>,
"content-type": "application/json",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"user-agent": StringMatching /Ghost\\\\/\\\\d\\+\\\\\\.\\\\d\\+\\\\\\.\\\\d\\+\\\\s\\\\\\(https:\\\\/\\\\/github\\.com\\\\/TryGhost\\\\/Ghost\\\\\\)/,
}
`;

exports[`tag.* events tag.deleted event is triggered 2: [body] 1`] = `
Object {
"tag": Object {
"current": Object {},
"previous": Object {
"accent_color": null,
"canonical_url": null,
"codeinjection_foot": null,
"codeinjection_head": null,
"created_at": StringMatching /\\\\d\\{4\\}-\\\\d\\{2\\}-\\\\d\\{2\\}T\\\\d\\{2\\}:\\\\d\\{2\\}:\\\\d\\{2\\}\\\\\\.000Z/,
"description": Any<String>,
"feature_image": null,
"id": StringMatching /\\[a-f0-9\\]\\{24\\}/,
"meta_description": null,
"meta_title": null,
"name": "Test Tag 2",
"og_description": null,
"og_image": null,
"og_title": null,
"slug": "test-tag-2",
"twitter_description": null,
"twitter_image": null,
"twitter_title": null,
"updated_at": StringMatching /\\\\d\\{4\\}-\\\\d\\{2\\}-\\\\d\\{2\\}T\\\\d\\{2\\}:\\\\d\\{2\\}:\\\\d\\{2\\}\\\\\\.000Z/,
"visibility": "public",
},
},
}
`;
46 changes: 43 additions & 3 deletions ghost/core/test/e2e-webhooks/tags.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ const tagSnapshot = {
created_at: anyISODateTime,
description: anyString,
id: anyObjectId,
updated_at: anyISODateTime,
url: anyLocalURL
updated_at: anyISODateTime
};

describe('tag.* events', function () {
Expand Down Expand Up @@ -56,7 +55,48 @@ describe('tag.* events', function () {
})
.matchBodySnapshot({
tag: {
current: tagSnapshot
current: {...tagSnapshot, url: anyLocalURL}
}
});
});

it('tag.deleted event is triggered', async function () {
const webhookURL = 'https://test-webhook-receiver.com/tag-deleted/';
await webhookMockReceiver.mock(webhookURL);
await fixtureManager.insertWebhook({
event: 'tag.deleted',
url: webhookURL
});

const res = await adminAPIAgent
.post('tags/')
.body({
tags: [{
name: 'Test Tag 2',
slug: 'test-tag-2',
description: 'Test description'
}]
})
.expectStatus(201);

const id = res.body.tags[0].id;

await adminAPIAgent
.delete('tags/' + id)
.expectStatus(204);

await webhookMockReceiver.receivedRequest();

webhookMockReceiver
.matchHeaderSnapshot({
'content-version': anyContentVersion,
'content-length': anyNumber,
'user-agent': anyGhostAgent
})
.matchBodySnapshot({
tag: {
current: {},
previous: tagSnapshot
}
});
});
Expand Down