Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for page.added webhook #15548

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

JohnGrisham
Copy link
Contributor

@JohnGrisham JohnGrisham commented Oct 6, 2022

Added e2e tests for page.added webhook

Ref - #15537

@JohnGrisham JohnGrisham changed the title Added snapshot test and snapshot. Added e2e tests for page.added webhook Oct 6, 2022
@naz naz self-assigned this Oct 6, 2022
@naz naz self-requested a review October 6, 2022 23:39
@naz naz removed their assignment Oct 6, 2022
@naz naz mentioned this pull request Oct 7, 2022
29 tasks
Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @JohnGrisham . I've requested couple very minor changes, otherwise it's ready to land in main 👍

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Note from our bot: Some changes have been requested on this pull request. Updating your code is great, but won't notify us, so please leave a comment so that we (and our bot) can see when you've made the changes. Thank you 🙏

@JohnGrisham JohnGrisham force-pushed the johng/page-add-webhook-test branch from d60ba76 to 35fe383 Compare October 7, 2022 17:56
@JohnGrisham JohnGrisham requested a review from naz October 7, 2022 18:05
Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good to go into main. Thanks @JohnGrisham 🙌
A little note, could you please make sure the changes come squashed (as a single commit) and the commit message follows Ghost's contributor guidelines 🙏

refs TryGhost#15537
snapshot test created to add confidence to webhook stability and increase overall test coverage.
@JohnGrisham JohnGrisham force-pushed the johng/page-add-webhook-test branch from 35fe383 to a97e24f Compare October 10, 2022 12:48
@JohnGrisham JohnGrisham requested a review from naz October 10, 2022 12:49
@JohnGrisham
Copy link
Contributor Author

Changes were made and the commits consolidated into one. Thanks for your help!

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 52.46% // Head: 52.42% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a97e24f) compared to base (ff4f93f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15548      +/-   ##
==========================================
- Coverage   52.46%   52.42%   -0.05%     
==========================================
  Files        1433     1438       +5     
  Lines       92890    93033     +143     
  Branches    10358    10393      +35     
==========================================
+ Hits        48739    48773      +34     
- Misses      42934    43035     +101     
- Partials     1217     1225       +8     
Impacted Files Coverage Δ
ghost/admin/app/helpers/gh-price-amount.js 44.44% <0.00%> (-22.23%) ⬇️
ghost/admin/app/components/posts-list/list-item.js 40.00% <0.00%> (-18.34%) ⬇️
ghost/admin/app/helpers/gh-format-post-time.js 83.33% <0.00%> (-8.34%) ⬇️
ghost/admin/app/controllers/pages.js 66.66% <0.00%> (-8.34%) ⬇️
ghost/admin/app/controllers/posts.js 65.62% <0.00%> (-6.44%) ⬇️
ghost/admin/app/controllers/settings/navigation.js 76.19% <0.00%> (-6.42%) ⬇️
ghost/admin/app/services/custom-views.js 76.19% <0.00%> (-4.27%) ⬇️
ghost/admin/app/routes/settings/general.js 75.86% <0.00%> (-1.56%) ⬇️
ghost/admin/app/components/gh-image-uploader.js 84.35% <0.00%> (-1.37%) ⬇️
ghost/admin/app/utils/publish-options.js 75.72% <0.00%> (-1.16%) ⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErisDS ErisDS merged commit c41f431 into TryGhost:main Oct 10, 2022
@ErisDS
Copy link
Member

ErisDS commented Oct 10, 2022

Hi @JohnGrisham thanks so much for this PR. It has now been merged 🎉

I'm not sure if you found this through hacktoberfest, but I've added the accepted label to this PR to make sure it counts. We have plenty of open issues and ongoing projects for hacktoberfest and beyond. We would love to see you around again 👋

sam-lord pushed a commit that referenced this pull request Oct 17, 2022
refs: #15537

- snapshot test created to add confidence to webhook stability and increase overall test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants