-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added e2e tests for page.added webhook #15548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks @JohnGrisham . I've requested couple very minor changes, otherwise it's ready to land in main 👍
Note from our bot: Some changes have been requested on this pull request. Updating your code is great, but won't notify us, so please leave a comment so that we (and our bot) can see when you've made the changes. Thank you 🙏 |
d60ba76
to
35fe383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are good to go into main. Thanks @JohnGrisham 🙌
A little note, could you please make sure the changes come squashed (as a single commit) and the commit message follows Ghost's contributor guidelines 🙏
refs TryGhost#15537 snapshot test created to add confidence to webhook stability and increase overall test coverage.
35fe383
to
a97e24f
Compare
Changes were made and the commits consolidated into one. Thanks for your help! |
Codecov ReportBase: 52.46% // Head: 52.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15548 +/- ##
==========================================
- Coverage 52.46% 52.42% -0.05%
==========================================
Files 1433 1438 +5
Lines 92890 93033 +143
Branches 10358 10393 +35
==========================================
+ Hits 48739 48773 +34
- Misses 42934 43035 +101
- Partials 1217 1225 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi @JohnGrisham thanks so much for this PR. It has now been merged 🎉 I'm not sure if you found this through hacktoberfest, but I've added the accepted label to this PR to make sure it counts. We have plenty of open issues and ongoing projects for hacktoberfest and beyond. We would love to see you around again 👋 |
refs: #15537 - snapshot test created to add confidence to webhook stability and increase overall test coverage.
Added e2e tests for page.added webhook
Ref - #15537