Removed bluebird from frontend/meta #14940
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14940 +/- ##
=======================================
Coverage 52.60% 52.60%
=======================================
Files 1392 1392
Lines 89130 89137 +7
Branches 10131 10130 -1
=======================================
+ Hits 46884 46888 +4
- Misses 42194 42197 +3
Partials 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TryGhost#14940 another file that was using BB has been freed of the dependency. Both the files are core/frontend/meta/get-meta.js is dependent on image-dimensions.js in the same folder. BB was removed from image-dimensions in my previous commit
|
I re-ran all the tests on my end… everything passes. In the subsequent commits, I have removed BB from another file in the same folder. |
|
Hey @Navarjun, nice to see you here! Thank you for this PR, really appreciate you taking the time to help out. I've just updated the original issue to be a bit clearer that we need to remove catch predicates first (and why). I'll hold onto this PR and merge it once that work is done. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Issue TryGhost#14882 - Bluebird promise was being used for getting cached image sizes using .props method. It has been removed to be replaced by native promise using Promise.all
TryGhost#14940 another file that was using BB has been freed of the dependency. Both the files are core/frontend/meta/get-meta.js is dependent on image-dimensions.js in the same folder. BB was removed from image-dimensions in my previous commit
ErisDS
changed the title
|
Hey @Navarjun hope your'e doing well! We finally got rid of all the catch predicates, so I've merged this. Thanks again! |
Issue #14882