-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{{tiers}} helper has regression in 5.80 - "free" tier shown in list. #19796
Comments
github-actions
bot
added
the
needs:triage
[triage] this needs to be triaged by the Ghost team
label
Mar 4, 2024
sagzy
added a commit
that referenced
this issue
Mar 6, 2024
refs INC-36 fixes #19796 - The tiers-only paywall was incorrectly rendering "Free". Example: "This post is for subscribers of the Free, Silver and Gold tiers only" - Steps to reproduce the issue: 1. Create a post with public visibility, publish it 2. Then swap the visibility to specific tiers. The default selects all paid tiers. Leave it like that 3. Update the post. The paywall show Free, even though it should be showing only the paid tiers - This fix filters out the "free" tier when visibility is set to tiers, before updating a Post or a Page. The fix includes bulk updates from the list of Posts and Pages (right-click on a Post/Page > Change Access).
github-actions
bot
removed
the
needs:triage
[triage] this needs to be triaged by the Ghost team
label
Mar 6, 2024
sagzy
added a commit
that referenced
this issue
Mar 6, 2024
refs INC-36 fixes #19796 - The tiers-only paywall was incorrectly rendering "Free". Example: "This post is for subscribers of the Free, Silver and Gold tiers only" - Steps to reproduce the issue: 1. Create a post with public visibility, publish it 2. Then swap the visibility to specific tiers. The default selects all paid tiers. Leave it like that 3. Update the post. The paywall show Free, even though it should be showing only the paid tiers - This fix filters out the "free" tier when visibility is set to tiers, before updating a Post or a Page. The fix includes bulk updates from the list of Posts and Pages (right-click on a Post/Page > Change Access).
royalfig
pushed a commit
that referenced
this issue
Mar 25, 2024
refs INC-36 fixes #19796 - The tiers-only paywall was incorrectly rendering "Free". Example: "This post is for subscribers of the Free, Silver and Gold tiers only" - Steps to reproduce the issue: 1. Create a post with public visibility, publish it 2. Then swap the visibility to specific tiers. The default selects all paid tiers. Leave it like that 3. Update the post. The paywall show Free, even though it should be showing only the paid tiers - This fix filters out the "free" tier when visibility is set to tiers, before updating a Post or a Page. The fix includes bulk updates from the list of Posts and Pages (right-click on a Post/Page > Change Access).
royalfig
pushed a commit
that referenced
this issue
Mar 25, 2024
refs INC-36 fixes #19796 - The tiers-only paywall was incorrectly rendering "Free". Example: "This post is for subscribers of the Free, Silver and Gold tiers only" - Steps to reproduce the issue: 1. Create a post with public visibility, publish it 2. Then swap the visibility to specific tiers. The default selects all paid tiers. Leave it like that 3. Update the post. The paywall show Free, even though it should be showing only the paid tiers - This fix filters out the "free" tier when visibility is set to tiers, before updating a Post or a Page. The fix includes bulk updates from the list of Posts and Pages (right-click on a Post/Page > Change Access).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Summary
The {{tiers}} helper is including the Free tier in the list of tiers with access, even for posts set only to a paid tier.
These are posts set to a specific tier access only. Here’s 5.80 (running Source latest)
And here’s 5.79, also Source latest:
Both are on Ghost Pro - it’s just a difference between whether they’re in the early or late roll-out group, looks like!
Steps to Reproduce
Install 5.80, hook up to Stripe, create a tier. Create a post restricted to that tier. Browse to the post while not logged in as a user with access.
Ghost Version
Ghost Pro
Node.js Version
Ghost Pro
How did you install Ghost?
Ghost Pro
Database type
MySQL 8
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: