Removed emojis from i18n strings

refs #15502 - these aren't going to change across languages so we can exclude them from the strings to simplify things
TryGhost · Mar 16, 2023 · 7a1f08e · 7a1f08e
1 parent 6760bc1
commit 7a1f08e
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/ghost/core/core/server/services/members/api.js b/ghost/core/core/server/services/members/api.js
@@ -59,16 +59,16 @@ function createApiInstance(config) {
                 const siteTitle = settingsCache.get('title');
                 switch (type) {
                 case 'subscribe':
-                    return t(`📫 Confirm your subscription to {{siteTitle}}`, {siteTitle});
+                    return `📫 ${t(`Confirm your subscription to {{siteTitle}}`, {siteTitle})}`;
                 case 'signup':
-                    return t(`🙌 Complete your sign up to {{siteTitle}}!`, {siteTitle});
+                    return `🙌 ${t(`Complete your sign up to {{siteTitle}}!`, {siteTitle})}`;
                 case 'signup-paid':
-                    return t(`🙌 Thank you for signing up to {{siteTitle}}!`, {siteTitle});
+                    return `🙌 ${t(`Thank you for signing up to {{siteTitle}}!`, {siteTitle})}`;
                 case 'updateEmail':
-                    return t(`📫 Confirm your email update for {{siteTitle}}!`, {siteTitle});
+                    return `📫 ${t(`Confirm your email update for {{siteTitle}}!`, {siteTitle})}`;
                 case 'signin':
                 default:
-                    return t(`🔑 Secure sign in link for {{siteTitle}}`, {siteTitle});
+                    return `🔑 ${t(`Secure sign in link for {{siteTitle}}`, {siteTitle})}`;
                 }
             },
             getText(url, type, email) {

diff --git a/ghost/core/core/server/services/members/emails/signin.js b/ghost/core/core/server/services/members/emails/signin.js
@@ -4,7 +4,7 @@ module.exports = ({t, siteTitle, email, url, accentColor = '#15212A', siteDomain
   <head>
     <meta name="viewport" content="width=device-width">
     <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
-    <title>${t('🔑 Secure sign in link for {{siteTitle}}', {siteTitle})}</title>
+    <title>🔑 ${t('Secure sign in link for {{siteTitle}}', {siteTitle})}</title>
     <style>
     /* -------------------------------------
         RESPONSIVE AND MOBILE FRIENDLY STYLES

diff --git a/ghost/i18n/locales/en/ghost.json b/ghost/i18n/locales/en/ghost.json
@@ -1,19 +1,19 @@
 {
-    "📫 Confirm your email update for {{siteTitle}}!": "",
-    "📫 Confirm your subscription to {{siteTitle}}": "",
-    "🔑 Secure sign in link for {{siteTitle}}": "",
-    "🙌 Complete your sign up to {{siteTitle}}!": "",
-    "🙌 Thank you for signing up to {{siteTitle}}!": "",
     "All the best!": "",
+    "Complete your sign up to {{siteTitle}}!": "",
+    "Confirm your email update for {{siteTitle}}!": "",
+    "Confirm your subscription to {{siteTitle}}": "",
     "For your security, the link will expire in 24 hours time.": "",
     "Hey there,": "",
     "If you did not make this request, you can safely ignore this email.": "",
     "If you did not make this request, you can simply delete this message.": "",
     "Please confirm your email address with this link:": "",
+    "Secure sign in link for {{siteTitle}}": "",
     "See you soon!": "",
     "Sent to {{email}}": "",
     "Sign in to {{siteTitle}}": "",
     "Tap the link below to complete the signup process for {{siteTitle}}, and be automatically signed in:": "",
+    "Thank you for signing up to {{siteTitle}}!": "",
     "Thank you for subscribing to {{siteTitle}}!": "",
     "Thank you for subscribing to {{siteTitle}}. Tap the link below to be automatically signed in:": "",
     "This email address will not be used.": "",

diff --git a/ghost/i18n/locales/nl/ghost.json b/ghost/i18n/locales/nl/ghost.json
@@ -1,19 +1,19 @@
 {
-    "📫 Confirm your email update for {{siteTitle}}!": "",
-    "📫 Confirm your subscription to {{siteTitle}}": "",
-    "🔑 Secure sign in link for {{siteTitle}}": "",
-    "🙌 Complete your sign up to {{siteTitle}}!": "",
-    "🙌 Thank you for signing up to {{siteTitle}}!": "",
     "All the best!": "",
+    "Complete your sign up to {{siteTitle}}!": "",
+    "Confirm your email update for {{siteTitle}}!": "",
+    "Confirm your subscription to {{siteTitle}}": "",
     "For your security, the link will expire in 24 hours time.": "",
     "Hey there,": "",
     "If you did not make this request, you can safely ignore this email.": "",
     "If you did not make this request, you can simply delete this message.": "",
     "Please confirm your email address with this link:": "",
+    "Secure sign in link for {{siteTitle}}": "",
     "See you soon!": "",
     "Sent to {{email}}": "",
     "Sign in to {{siteTitle}}": "",
     "Tap the link below to complete the signup process for {{siteTitle}}, and be automatically signed in:": "",
+    "Thank you for signing up to {{siteTitle}}!": "",
     "Thank you for subscribing to {{siteTitle}}!": "",
     "Thank you for subscribing to {{siteTitle}}. Tap the link below to be automatically signed in:": "",
     "This email address will not be used.": "",