Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Text for Paid Posts #901

Closed
danielherndon opened this issue Oct 3, 2022 · 5 comments
Closed

Button Text for Paid Posts #901

danielherndon opened this issue Oct 3, 2022 · 5 comments

Comments

@danielherndon
Copy link

Hey folks,

Just discovered (Casper) that when a post is for paying subscribers, and a logged-in free subscriber views it, the text on the button is white and doesn't appear.

In an effort to ensure I'm seeing the issue clearly, I removed all my code injections to see if my CSS additions were the source of the problem, but that didn't change anything.

Screen Shot 2022-10-03 at 5 12 18 PM

Excited to finally see what that button says!

@minimaluminium
Copy link
Member

Hey @danielherndon,

I couldn't reproduce this. Would you be able to give me an URL to the post that has this issue?

@danielherndon
Copy link
Author

Thanks for checking.

This link is one where I am seeing this: https://www.danielkherndon.com/cereal-and-ivy-league/

You have to be a logged-in user who is not a paid user.

One thing I have not checked is to see if this was something caused by cache on my browser, although I would be surprised.

@minimaluminium
Copy link
Member

minimaluminium commented Oct 10, 2022

I confirm that it's reproducible and it's not related with your browser cache. We're aware of this issue and let you know when it's fixed. In the meantime, could you add this CSS workaround as a code injection until it gets fixed?

<style>
    .gh-post-upgrade-cta a.gh-btn {
        color: var(--ghost-accent-color);
    }
</style>

@danielherndon
Copy link
Author

Thank You! I appreciate the help.

rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Oct 13, 2022
refs TryGhost/Casper#901

- the site accent color property on default cta for upgrade link had a typo and was using wrong accent color property
rishabhgrg added a commit to TryGhost/Ghost that referenced this issue Oct 13, 2022
refs TryGhost/Casper#901

- the site accent color property on default cta for upgrade link had a typo and was using wrong property
@rishabhgrg
Copy link
Contributor

Closed with TryGhost/Ghost@e05889c, will be out in next Ghost release.

sam-lord pushed a commit to TryGhost/Ghost that referenced this issue Oct 17, 2022
refs TryGhost/Casper#901

- the site accent color property on default cta for upgrade link had a typo and was using wrong property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants