deps: [email protected] #34
Conversation
no issue - move `validator-js` from a bower dependency to an npm dependency - remove `validator` global from `.jshintrc` - update all uses of `validator.*` to use ES6 modules (should cut down on the amount of code imported) - remove custom validator extensions - uses of `validator.empty` have been updated to use Ember's `isBlank` that is imported as if it was an ES6 module via `ember-cli-shims` (we should probably start using `ember-cli-shims` everywhere as it paves the way for migrating to true ES6 modules once Ember has been officially split up)
|
@kevinansfield The validations refactor should (I hope) remove the need for the validator.js library. |
|
If validator.js is removed, how will the client side do things like determining if a URL is valid? |
|
@ErisDS there's validation ulitities built into ember-changeset-validations 😄 |
|
The benefit to using validator.js on both the client and server is that you can be sure they'll both permit/reject the same things. So for complex things like email addresses and urls, there is no mis-match between what is accepted. I'm just flagging this up as something to consider. If you run into issues with edge cases, it may be better to have custom validators wrap validator.js? |
|
👍 yeah true, will definitely re-evaluate as the refactor goes farther along. |
|
going to close this as it's being handled in the validation refactor |
no issue
validator-jsfrom a bower dependency to an npm dependencyvalidatorglobal from.jshintrcvalidator.*to use ES6 modules (should cut down on the amount of code imported)validator.emptyhave been updated to use Ember'sisBlankthat is imported as if it was an ES6 module viaember-cli-shims(we should probably start usingember-cli-shimseverywhere as it paves the way for migrating to true ES6 modules once Ember has been officially split up)This is currently failing but I haven't had a chance to properly debug yet. I believe it may be something related to validatorjs/validator.js#496 (diff)