Small fixes and improvements #52
Conversation
Diyagi
commented
May 11, 2024
•
Diyagi
commented
- Fixes log tail not running
- Improves shutdown to be more gracefully
- Silences AVXs grep check
- Fixes Servername env var check so spaces in the string can work (tho, its not needed tbh, the gameserver itself has its own env vars)
- Removes the timezone set, tzdata already reads the TZ env and adjusts it accordingly
|
Love this change, haven't tested myself but really waiting for a graceful shutdown since I am really paranoid about losing hours worth of save data because of a bad shutdown. @TrueOsiris pls review when you get time :) |
start.sh
Outdated
| /usr/bin/tail -f /mnt/vrising/persistentdata/VRisingServer.log | ||
| DISPLAY=:0.0 wine64 /mnt/vrising/server/VRisingServer.exe -persistentDataPath $p -serverName "$SERVERNAME" -saveName "$WORLDNAME" -logFile "$p/VRisingServer.log" "$game_port" "$query_port" 2>&1 & | ||
|
|
There was a problem hiding this comment.
Not sure if its worth it, but can we have logs saved for last 3 runs?
like using VRisingServer-$(date +'%Y%m%d-%H%M').log (example: VRisingServer-20240513-2348.log)
We can maybe cleanup old logs when the script starts. This is helpful in case someone needs to go over old logs after starting a server.
Scenario:
- User started server
- Realized that the server didn't exit correctly / Crashed
- Tries to figure out what happened by going over old logs.
There was a problem hiding this comment.
i dont think VRisingServer.log is ever wiped, every time the server starts it seems that it just writes to the end of the file, that said, it would be better if each run had their logs split by files, i will see what i can come up with.
|
Hi, could you please explain the following: |
bc if we dont, it will only reach the tail after the gameserver process exits. |
@TrueOsiris seems to have implemented logs changes themselves, You can refer the changes in their last commits and suggest changes if you feel like! :) Thanks for the PR though, running the server on my Dedicated VPS, and its working flawlessly! |
