Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deployments action #24

Closed
wants to merge 5 commits into from
Closed

Remove deployments action #24

wants to merge 5 commits into from

Conversation

KD-7
Copy link
Contributor

@KD-7 KD-7 commented Feb 15, 2023

I have written an action that deletes the deployments in our repo, this fixes #18. Since for now we won't be using that feature should we integrate this functionality or not?

@KD-7 KD-7 requested a review from yuxqiu February 16, 2023 13:27
@yuxqiu
Copy link
Collaborator

yuxqiu commented Feb 16, 2023

What's the purpose of this PR? I don't quite get it. Where can we find our previous deployments?

@KD-7
Copy link
Contributor Author

KD-7 commented Feb 16, 2023

What's the purpose of this PR? I don't quite get it. Where can we find our previous deployments?

Thats the point, previously we deployed our documentation using a github-pages environment. When these deployments fail or are no longer in use they leave a history/log on our repo. This action can be configured to clean environments/failed deployments etc.
I used this action to get rid of the deployments, (there are no more banners under the PRs saying this branch hasnt been deployed) and the github-pages environment.

The question is whether we should keep this action in the future or whether its not necessary as we are using readthedocs now.

@yuxqiu
Copy link
Collaborator

yuxqiu commented Feb 16, 2023

What's the purpose of this PR? I don't quite get it. Where can we find our previous deployments?

Thats the point, previously we deployed our documentation using a github-pages environment. When these deployments fail or are no longer in use they leave a history/log on our repo. This action can be configured to clean environments/failed deployments etc. I used this action to get rid of the deployments, (there are no more banners under the PRs saying this branch hasnt been deployed) and the github-pages environment.

The question is whether we should keep this action in the future or whether its not necessary as we are using readthedocs now.

So, the deployments have been removed. Now, we need to decide if we need to keep this action?

@KD-7
Copy link
Contributor Author

KD-7 commented Feb 16, 2023

What's the purpose of this PR? I don't quite get it. Where can we find our previous deployments?

Thats the point, previously we deployed our documentation using a github-pages environment. When these deployments fail or are no longer in use they leave a history/log on our repo. This action can be configured to clean environments/failed deployments etc. I used this action to get rid of the deployments, (there are no more banners under the PRs saying this branch hasnt been deployed) and the github-pages environment.
The question is whether we should keep this action in the future or whether its not necessary as we are using readthedocs now.

So, the deployments have been removed. Now, we need to decide if we need to keep this action?

Exactly

@yuxqiu
Copy link
Collaborator

yuxqiu commented Feb 16, 2023

What's the purpose of this PR? I don't quite get it. Where can we find our previous deployments?

Thats the point, previously we deployed our documentation using a github-pages environment. When these deployments fail or are no longer in use they leave a history/log on our repo. This action can be configured to clean environments/failed deployments etc. I used this action to get rid of the deployments, (there are no more banners under the PRs saying this branch hasnt been deployed) and the github-pages environment.
The question is whether we should keep this action in the future or whether its not necessary as we are using readthedocs now.

So, the deployments have been removed. Now, we need to decide if we need to keep this action?

Exactly

In my opinion, we don't need to keep this because we have deleted all previous deployments and won't be deploying anything in the near future. Even if we need to use this one day, I think we can easily set up actions and clean up deployments as the action file can be found from our PR history.

@KD-7 KD-7 closed this Feb 16, 2023
@KD-7 KD-7 deleted the remove-deployments branch February 16, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to remove inactive deployments
2 participants