-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deployments action #24
Conversation
What's the purpose of this PR? I don't quite get it. Where can we find our previous deployments? |
Thats the point, previously we deployed our documentation using a github-pages environment. When these deployments fail or are no longer in use they leave a history/log on our repo. This action can be configured to clean environments/failed deployments etc. The question is whether we should keep this action in the future or whether its not necessary as we are using readthedocs now. |
So, the deployments have been removed. Now, we need to decide if we need to keep this action? |
Exactly |
In my opinion, we don't need to keep this because we have deleted all previous deployments and won't be deploying anything in the near future. Even if we need to use this one day, I think we can easily set up actions and clean up deployments as the action file can be found from our PR history. |
I have written an action that deletes the deployments in our repo, this fixes #18. Since for now we won't be using that feature should we integrate this functionality or not?