Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Move @ensdomains/ens and @ensdomains/resolver to devDependencies #720

Merged
merged 3 commits into from
Jul 7, 2022
Merged

🔧 Move @ensdomains/ens and @ensdomains/resolver to devDependencies #720

merged 3 commits into from
Jul 7, 2022

Conversation

DimitarNestorov
Copy link
Contributor

@DimitarNestorov DimitarNestorov commented May 5, 2022

Before After
image image

I published the fork here: https://www.npmjs.com/package/ethereum-waffle-ens-fork

Repo where I tested ethereum-waffle-ens-fork: https://github.com/dimitarnestorov/bankfair-contracts

Script I used to test:

// @ethereum-waffle/ens was overriden by [email protected]
const {deployENS} = require('@ethereum-waffle/ens');
const {MockProvider}= require('@ethereum-waffle/provider');

(async () => {
	const provider = new MockProvider();
	const [wallet] = provider.getWallets();
	const ens = await deployENS(wallet);
	await ens.createTopLevelDomain('test');
	console.log({ens, wallet, provider, callHistory: provider.callHistory})
})()

Related issues: #501

Closes #592

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

🦋 Changeset detected

Latest commit: ab6bac0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ethereum-waffle/ens Patch
@ethereum-waffle/provider Patch
@ethereum-waffle/chai Patch
ethereum-waffle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rzadp rzadp changed the title Move @ensdomains/ens and @ensdomains/resolver to devDependencies 🔧 Move @ensdomains/ens and @ensdomains/resolver to devDependencies Jul 7, 2022
@rzadp rzadp merged commit 9d3a171 into TrueFiEng:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants