-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💫 Added withNamedArgs method to the Chai emit matcher #456
Conversation
🦋 Changeset detectedLatest commit: 5fdbead The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
waffle-chai/package.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "@ethereum-waffle/chai", | |||
"description": "A sweet set of chai matchers for your blockchain testing needs.", | |||
"version": "3.3.0", | |||
"version": "3.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to update version - it will be updated by github bot (changesets).
Any plans to add something thing this? I am running into the same issue with a need to have an optional/unpredictable arg. |
I think this is an incredibly useful feature for any non-trivial contracts. Can someone take a look again from the waffle project and give directions? Any objections? Anything that can be fixed? |
Thanks to everyone for their input. |
Improved error messages for existing emit matchers
This is part of feature request #437 to check against a subset of args emitted in events