Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💫 Added withNamedArgs method to the Chai emit matcher #456

Merged
merged 5 commits into from
Jul 21, 2022

Conversation

naddison36
Copy link
Contributor

@naddison36 naddison36 commented Mar 3, 2021

Improved error messages for existing emit matchers

This is part of feature request #437 to check against a subset of args emitted in events

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2021

🦋 Changeset detected

Latest commit: 5fdbead

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ethereum-waffle/chai Patch
ethereum-waffle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -1,7 +1,7 @@
{
"name": "@ethereum-waffle/chai",
"description": "A sweet set of chai matchers for your blockchain testing needs.",
"version": "3.3.0",
"version": "3.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update version - it will be updated by github bot (changesets).

@xiaolin
Copy link

xiaolin commented Aug 29, 2021

Any plans to add something thing this? I am running into the same issue with a need to have an optional/unpredictable arg.

@marekkirejczyk
Copy link
Contributor

@vanruch

@KholdStare
Copy link

I think this is an incredibly useful feature for any non-trivial contracts. Can someone take a look again from the waffle project and give directions? Any objections? Anything that can be fixed?

@rzadp
Copy link
Contributor

rzadp commented May 16, 2022

Thanks to everyone for their input.
We have more bandwidth now and will take another look into this in the upcoming days.
Definitely looks like a good method to have.

@rzadp rzadp changed the title Added withNamedArgs method to the Chai emit matcher 💫 Added withNamedArgs method to the Chai emit matcher Jul 21, 2022
@rzadp rzadp merged commit 62dd2f9 into TrueFiEng:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants