🪛 Add eth_sendTransaction calls to call history (#715)

TrueFiEng · Apr 27, 2022 · 671f139 · 671f139
1 parent 51e05d8
commit 671f139
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/tame-walls-speak.md b/.changeset/tame-walls-speak.md
@@ -0,0 +1,5 @@
+---
+"@ethereum-waffle/provider": patch
+---
+
+Include eth_sendTransaction when recording call history
diff --git a/waffle-provider/src/CallHistory.ts b/waffle-provider/src/CallHistory.ts
@@ -77,12 +77,13 @@ export class CallHistory {
           /**
            * A method can be:
            * - `eth_call` - a query to the node,
-           * - `eth_sendRawTransaction` - a transaction,
+           * - `eth_sendRawTransaction` - a raw transaction,
+           * - `eth_sendTransaction` - a transaction,
            * - `eth_estimateGas` - gas estimation, typically precedes `eth_sendRawTransaction`.
            */
-          if (method === 'eth_call') { // Record a query.
+          if (method === 'eth_call' || method === 'eth_sendTransaction') { // Record a query or a transaction.
             callHistory.recordedCalls.push(toRecordedCall(args[0]?.params?.[0]));
-          } else if (method === 'eth_sendRawTransaction') { // Record a transaction.
+          } else if (method === 'eth_sendRawTransaction') { // Record a raw transaction.
             const parsedTx = parseTransaction(args[0]?.params?.[0]);
             callHistory.recordedCalls.push(toRecordedCall(parsedTx));
           }