Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiline string type, make LdtkAsset clonable, print the field name in unknown field error #90

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

jrasanen
Copy link
Contributor

Make LdtkAsset clonable

This improves the ergonomics when used with bevy_asset_loader

Improve error messages for unknown fields

Add the name of unsupported field into the error message

Multilines

Support Multilines -type, it's identical to the string, but it can contain Markdown formatting in the LDtk editor:

{ "__identifier": "label", "__value": "Strange crate", "__type": "String", "__tile": null, "defUid": 65, "realEditorValues": [{
    "id": "V_String",
    "params": ["Strange crate"]
}] },
{ "__identifier": "description", "__value": "The crate has some military logo on it.", "__type": "Multilines", "__tile": null, "defUid": 64, "realEditorValues": [{
    "id": "V_String",
    "params": ["The crate has some military logo on it."]
}] },

Multilines are the same as strings, but in the LDtk editor they can contain
markdown formatting
@Trouv
Copy link
Owner

Trouv commented Jun 14, 2022

Sorry for taking so long to get back to this. Could you cargo fmt it before I merge?

@jrasanen
Copy link
Contributor Author

Hey! No worries, I've been busy with life, I'll try to remember to do it as soon as possible.

@Trouv
Copy link
Owner

Trouv commented Jun 23, 2022

Thanks! Merging

@Trouv Trouv merged commit fe2569f into Trouv:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants