build: use a git revision dependency for bevy_ecs_tilemap instead of a git branch patch #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #321
Currently, we're using a patch to depend on
bevy_ecs_tilemap. This places a burden on the user to use a similar patch in their ownCargo.toml. We're also using themainbranch ofbevy_ecs_tilemapin this patch. This can lead to issues when updates occur to that branch of thebevy_ecs_tilemaprepository, as new users andcargo updaters will pull in any new changes to that repo, even breaking ones. This is currently affecting our CI.This PR's changes will ultimately be overwritten soon by an update to bevy 0.14 (#325), but merging this sooner will help set the standard for development of this project inbetween
bevy_ecs_tilemapreleases in the future, and also unblock other PRs whose CI checks are affected (#306).