src: handle empty Maybe in uv binding initialize

This can fail when terminating a Worker that loads the `uv` binding at the same time. Refs: nodejs#25061 (comment) Fixes: nodejs#25134 PR-URL: nodejs#25079 Backport-PR-URL: nodejs#28832 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Trott · Jul 26, 2019 · ca4a22e · ca4a22e
1 parent 4a607fa
commit ca4a22e
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/uv.cc b/src/uv.cc
@@ -71,9 +71,11 @@ void Initialize(Local<Object> target,
   Local<Array> arr = Array::New(isolate, 2);                                  \
   arr->Set(0, OneByteString(isolate, #name));                                 \
   arr->Set(1, OneByteString(isolate, msg));                                   \
-  err_map->Set(context,                                                       \
-               Integer::New(isolate, UV_##name),                              \
-               arr).ToLocalChecked();                                         \
+  if (err_map->Set(context,                                                   \
+                   Integer::New(isolate, UV_##name),                          \
+                   arr).IsEmpty()) {                                          \
+    return;                                                                   \
+  }                                                                           \
 } while (0);
   UV_ERRNO_MAP(V)
 #undef V