Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Doctrine's documentation (http://docs.doctrine-project.org/en/latest/reference/inheritance-mapping.html)
otherwise extending the class leads to errors such as described here : http://stackoverflow.com/questions/21536634/doctrine-query-crashing
There is hence an architecture choice to be made : either keep the
@ORM\MappedSuperclass
annotation or remove it.I personally think this is the bundle's user responsibility to extend the class should he need to persist the object, this is why I removed the
@ORM\Entity
annotation.