Implement an optional "simple" format #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of the stringified JSON object.
|
|
||
|
|
||
| function formatRecord(rec, format) { | ||
| var skip = ['hostname', 'level', 'msg', 'name', 'pid', 'time', 'v']; |
There was a problem hiding this comment.
What does this variable do? Is it just for reference? If so, can it just be a comment then?
|
@printscreen Thanks for your feedback – I deleted the unused |
|
Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
formatparameter that lets the user decide which format is being used. The default isjson, so it works just like before.The new
simpleformat only logs the log message, like the "-o simple" parameter in the Bunyan CLI.Fixes #14.