Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored and consolidated /calc commands #801

Merged

Conversation

theimperious1
Copy link
Contributor

This pull request consolidates all /calc commands into two new files: d.calc.ts and g.calc.ts. Additionally, the autocomplete functionality has been modified to ensure it correctly supports the benzo calculation command.

Added some validation checks as well:

  • Implemented comprehensive validation checks for all parameters across the /calc subcommands.
  • Ensured that these validation checks prevent user inputs that could lead to unintended responses or errors.

This is for issue #776.

Let me know if anything needs changing. I aimed to be semi-consistent with the way things were done elsewhere in the source code, but I'm sure some improvements could still be made.

IMPORTANT: I tested it and everything should work however I would appreciate it if someone would try out the nasal command and verify that the math still checks out. It should, I didn't touch that logic beyond moving it into g.calc.ts, but I don't want that to go through without someone who understands how to use it testing it since it's rather important that these provide accurate information.

@LunaUrsa
Copy link
Contributor

LunaUrsa commented Jul 1, 2024

fixes #590

@LunaUrsa LunaUrsa merged commit 4dff829 into TripSit:main Aug 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants