Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed startup version check not checking for error #8226

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fixed startup version check not checking for error #8226

merged 1 commit into from
Oct 18, 2024

Conversation

qstokkink
Copy link
Contributor

This PR:

  • Fixes the startup version check not checking for error responses.

When browsing to the Tribler URL with an invalid key, you would see this (doubled because I run npm run dev):

screenshot

@qstokkink qstokkink marked this pull request as ready for review October 18, 2024 13:41
@qstokkink qstokkink changed the title Fixed startup version check not checking for error READY: Fixed startup version check not checking for error Oct 18, 2024
@qstokkink qstokkink changed the title READY: Fixed startup version check not checking for error Fixed startup version check not checking for error Oct 18, 2024
@qstokkink qstokkink merged commit faef65d into Tribler:main Oct 18, 2024
7 checks passed
@qstokkink qstokkink deleted the fix_startup_version_check branch October 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qstokkink @egbertbouman