Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a messagebox when an error occurs during startup #8196

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

egbertbouman
Copy link
Member

Fixes #8195.

Error in case of a currupted private key:
image

In case of a import error:
image

@egbertbouman
Copy link
Member Author

validate

@egbertbouman egbertbouman marked this pull request as ready for review October 7, 2024 10:13
Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge the show_error function into the run_tribler.py file, or rename the utilities.py file to something more descriptive if this is expected to be used in other files in the future.

I had the displeasure of dealing with the aftermath of the previous utilities and it still triggers my PTSD: https://github.com/Tribler/tribler/tree/release/7.15/src/tribler/core/utilities

@egbertbouman
Copy link
Member Author

I can't say I agree, but OK. I've chucked it into run_tribler.py. 🤷

Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have quite strong feelings about this matter.

@egbertbouman
Copy link
Member Author

validate

@egbertbouman egbertbouman merged commit 8d63b8e into Tribler:main Oct 8, 2024
7 checks passed
@egbertbouman egbertbouman deleted the messagebox branch October 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Create an error mode session
2 participants