Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READY: Set active downloads/seeds to unlimited #8154

Closed
wants to merge 1 commit into from

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Sep 13, 2024

Related to #6801

This PR:

  • Updates active_downloads and active_seeds to be unlimited by default (capped to 500 in total by libtorrent internally).

This seems like a better default than a max of 3 downloads and 5 seeds.

screenshot

A follow-up PR should make this configurable in the GUI.

@qstokkink qstokkink changed the title Set active downloads/seeds to unlimited READY: Set active downloads/seeds to unlimited Sep 13, 2024
@qstokkink qstokkink marked this pull request as ready for review September 13, 2024 13:46
Copy link
Member

@egbertbouman egbertbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these settings apply to auto-managed downloads. Are downloads auto-managed nowadays?

@qstokkink
Copy link
Contributor Author

I believe so, from the docs:

By default, torrents are auto-managed, which means libtorrent will pause, resume, scrape them and take them out of upload-mode automatically.

@egbertbouman
Copy link
Member

But isn't the flag cleared by:

# In LibTorrent auto_managed flag is now on by default, and as a result
# any torrent"s state can change from Stopped to Downloading at any time.
# Here we unset this flag to prevent auto-resuming of stopped torrents.
if hasattr(self.handle, "unset_flags"):
self.handle.unset_flags(lt.add_torrent_params_flags_t.flag_auto_managed)

@qstokkink
Copy link
Contributor Author

Indeed it is.

The auto managed flag IS deprecated. So, just to be sure, I double-checked whether libtorrent somehow automatically enabled auto managing anyway. This does not seem to be the case. I can download more than 3 torrents at the same time:

I guess the original issue was then already resolved at some point. So, I will close that.

@qstokkink qstokkink closed this Sep 13, 2024
@qstokkink qstokkink deleted the upd_active_to_unlimited branch September 13, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants