Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncaught exception handler to GUI #8150

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Sep 12, 2024

Related to #8141

This PR:

  • Adds a last line of defense for uncaught TypeScript errors.
  • Removes the interceptors from Axios responses.

This PR does not implement proper handling per core response yet. This is only the last resort for when "clean" error handling fails.

@qstokkink qstokkink force-pushed the fix_gui_error_catching_poc2 branch 2 times, most recently from b8e2322 to 731cfce Compare September 12, 2024 14:35
@qstokkink qstokkink force-pushed the fix_gui_error_catching_poc2 branch from 731cfce to 5f0aab9 Compare September 13, 2024 07:49
@qstokkink qstokkink changed the title WIP: Add uncaught exception handler to GUI READY: Add uncaught exception handler to GUI Sep 13, 2024
@qstokkink qstokkink marked this pull request as ready for review September 13, 2024 07:53
@qstokkink qstokkink changed the title READY: Add uncaught exception handler to GUI Add uncaught exception handler to GUI Sep 13, 2024
@qstokkink qstokkink merged commit 6fe24bb into Tribler:main Sep 13, 2024
7 checks passed
@qstokkink qstokkink deleted the fix_gui_error_catching_poc2 branch September 13, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants