Store GUI settings in TriblerConfig #8101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egbertbouman
force-pushed
the
gui_settings
branch
from
e95ec77 to
7c083c4
Compare
qstokkink
reviewed
Aug 20, 2024
qstokkink
previously approved these changes
Aug 20, 2024
There was a problem hiding this comment.
I'll pre-approve, in case #8101 (comment) turns out to be a non-issue.
egbertbouman
force-pushed
the
gui_settings
branch
from
7c083c4 to
de25a38
Compare
egbertbouman
force-pushed
the
gui_settings
branch
from
de25a38 to
56b822c
Compare
qstokkink
approved these changes
Aug 20, 2024
|
validate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Tribler uses the browser's
localStorageto store the GUI settings. However, since we're using a default port of 0, the GUI settings are likely to be reset after every restart.This PR addresses this issue by avoiding the use of
localStorageand storing the GUI settings alongside the core settings instead.