-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to hide columns in the download table #8025
Conversation
Hi @heldersepu, thank you for contributing to Tribler! 🚀 This PR was created by an outside collaborator, so some checks were not run for security reasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. While hiding a column can be useful for some users, the way it is implemented has some usability issues:
-
Unexpected Behavior: Double-clicking a column header typically relates to sorting or adjusting the width of the column in many applications. Hiding a column by double-clicking could be counterintuitive for users accustomed to standard UI patterns.
-
Accidental Clicks: Users might accidentally double-click a header, expecting it to sort or adjust, and instead find the column has disappeared. Imagine the Name column disappears after a user accidentally double-clicks it. This could lead to confusion and frustration. It may be hard for a user to understand what has just happened, and it will look like a bug.
-
Lack of Reversibility: The absence of an immediate way to bring back the hidden column without restarting the application is a significant usability issue. Users should have the ability to easily undo the action, ideally through the same interface mechanism used to hide it (e.g., right-click the context menu to show/hide columns).
A more intuitive approach might be to implement a right-click context menu on the column headers. This would not only prevent accidental hiding but also enhance functionality by giving users more control.
@kozlovsky right-click context menu added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but one fix should be added.
After you apply the fix, can you please squash all commits in the PR branch to make the commit history easier to read?
Co-Authored-By: Alexander Kozlovsky <[email protected]>
a55addc
to
7e69e3b
Compare
Fix applied, and all commits have been squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you for the contribution!
This PR adds a simple way to hide columns in the download table
right clicking in the header
header().customContextMenuRequested,
will show a small menuin that menu we have options:
header().hideSection(index)