-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to remember download columns width #8020
Conversation
Hi @heldersepu, thank you for contributing to Tribler! 🚀 This PR was created by an outside collaborator, so some checks were not run for security reasons. |
Thanks for your PR! |
ff812fc
to
f22bd61
Compare
@egbertbouman correction applied... thanks for the tip, code looks simpler that way! |
Thanks, looks good! I'm fine with merging this PR as-is, but I just noticed that the header also has If you're up for it, you could save/restore the entire state of the downloads list in self.gui_settings.setValue("download_columns", self.downloads_list.header().saveState()) |
Let me experiment with that |
add settings to remember_columns width
@egbertbouman I made the following changes:
only disagreement with your suggestion I'm not saving onclose or restore_window_geometry instead doing it on:
just in case if we get a crash, the state is not affected because it saved immediately after change |
Nice, it's running smoothly and there's even a checkbox for it now 👍 |
it was fun! ... thanks @egbertbouman for pushing me in the right direction |
Are you tired of having to resize the columns in the download page all the time? me too...
This PR adds a couple of setting to set column width, for now i prefer to just have it as a "hidden" config option and in future versions we can add it in the UI, and more fancy stuff
This is how it looks like with my favorite options, I like the name to be the widest and the progress a bit wider than the default
Here is the new setting:
My goal is to make small changes as I get myself familiar with the code base, then I would be able to take on some more challenging issues