-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on_paste_event to handle pasting of magnet links #8008
Conversation
Hi @heldersepu, thank you for contributing to Tribler! 🚀 This PR was created by an outside collaborator, so some checks were not run for security reasons. |
Hi, @heldersepu! Thank you for your improvement. I see a lot of errors in the checks for this PR. However, they are not related to the changes in this PR and are caused by something else. |
@heldersepu, could you please rebase your branch on the most recent |
@drew2a done |
Thank you, @heldersepu! Two comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test test_clipboard
is causing the GUI tests to fail. It should be fixed.
There are two ways to address this, one proper but time-consuming, and the other quick but less desirable, which is to simply remove the test.
If you choose the proper method, here are a couple of options:
- Keep the test as is but try to mock
QApplication
or some parts of it. - Move the test to
test_gui.py
and adapt it to the style used in that file.
To verify correctness, you can run the entire test suite for the GUI folder. Currently, it results in an error.
... but Merging is so much easier... github gives us a button they call [Sync fork] Looking into the failing tests, when I started I noticed the |
It gives you a cleaner commit history. If you spend a lot of time doing bug fixing and figuring out when and how an error was introduced, you start to appreciate the clarity of a well-maintained commit history :) |
@heldersepu, thank you for your effort and cooperation. |
It really is my pleasure @drew2a ... |
A simple change to add magnet to the downloads with paste (
QKeySequence("Ctrl+v")
)this speeds up the many click steps, ideally more options will be added in the future..